Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.2 - Fix for deprecation notices #443

Merged
merged 1 commit into from
Aug 28, 2023
Merged

PHP 8.2 - Fix for deprecation notices #443

merged 1 commit into from
Aug 28, 2023

Conversation

divya-intelli
Copy link
Collaborator

Fixes #441

@divya-intelli divya-intelli added this to the 2.1.1 milestone Aug 28, 2023
shishir-intelli
shishir-intelli approved these changes Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@shishir-intelli shishir-intelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 28, 2023 •
edited
Loading

Codecov Report

Merging #443 (2db9089) into 2.x (58f2520) will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##                2.x     #443   +/-   ##
=========================================
  Coverage     49.24%   49.24%           
  Complexity     1997     1997           
=========================================
  Files           200      200           
  Lines          7398     7398           
=========================================
  Hits           3643     3643           
  Misses         3755     3755
Files Changed Coverage Δ
...gee_m10n_add_credit/src/Form/ConfirmUpdateForm.php 0.00% <0.00%> (ø)
...Entity/ListBuilder/PurchasedProductListBuilder.php 10.77% <ø> (ø)
src/Entity/PurchasedProduct.php 45.09% <100.00%> (ø)

@divya-intelli divya-intelli merged commit bf25f8f into apigee:2.x Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shishir-intelli shishir-intelli shishir-intelli approved these changes

@giteshk giteshk Awaiting requested review from giteshk

@kedarkhaire kedarkhaire Awaiting requested review from kedarkhaire

Assignees
No one assigned
Labels
PHP 8.2
Projects
Drupal-based Development Board
Status: Done
Milestone
2.1.1
Development

Successfully merging this pull request may close these issues.

PHP 8.2 Deprecation notice : Creation of dynamic property
2 participants
@divya-intelli @shishir-intelli