Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for deprecation notice : validate() might add void #465

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Fix for deprecation notice : validate() might add void #465

merged 1 commit into from
Oct 30, 2023

Conversation

divya-intelli
Copy link
Collaborator

Closes #460

@divya-intelli divya-intelli added this to the 2.1.2 milestone Oct 26, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023 •
edited
Loading

Codecov Report

Merging #465 (e8b9788) into 2.x (05d1029) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##                2.x     #465   +/-   ##
=========================================
  Coverage     49.24%   49.24%           
  Complexity     1997     1997           
=========================================
  Files           200      200           
  Lines          7399     7399           
=========================================
  Hits           3644     3644           
  Misses         3755     3755
Files Coverage Δ
...PriceRangeDefaultOutOfRangeConstraintValidator.php 83.33% <100.00%> (ø)
...eRangeMinimumGreaterMaximumConstraintValidator.php 75.00% <100.00%> (ø)
...riceRangeMinimumTopUpAmountConstraintValidator.php 72.41% <100.00%> (ø)

kedarkhaire
kedarkhaire approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@kedarkhaire kedarkhaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@divya-intelli divya-intelli merged commit 2257dc3 into apigee:2.x Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kedarkhaire kedarkhaire kedarkhaire approved these changes

@shishir-intelli shishir-intelli Awaiting requested review from shishir-intelli

Assignees
No one assigned
Labels
None yet
Projects
Drupal-based Development Board
Status: Done
Milestone
2.1.2
2 participants
@divya-intelli @kedarkhaire