Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please ignore devDependencies in deploynodeapp #31

Closed
tmarrs opened this issue Dec 30, 2015 · 6 comments
Closed

Please ignore devDependencies in deploynodeapp #31

tmarrs opened this issue Dec 30, 2015 · 6 comments

Comments

@tmarrs
Copy link

tmarrs commented Dec 30, 2015

I can't deploy on Apigee with my package.json "as is" with the -R option because the devDependencies that I use (e.g., gulp, etc.) are too large and exceeds the Proxy Bundle limit. As a workaround, I have to do the following:

  • Do npm install --production
  • Use the -U option

But this is still a defect. Please fix your deployment tool to use npm install --production. That way, you're just pulling in the dependencies from package.json, and everything works as expected.

@tmarrs tmarrs changed the title Please ignore devDependencies Please ignore devDependencies in deploynodeapp Dec 30, 2015
@gbrail
Copy link

gbrail commented Jan 15, 2016

Fixing this requires a change to Apigee Edge, because that's where NPM runs when apigeetool asks it to. I opened issue APIRT-2452 to track the resolution of this within Apigee.

@tmarrs
Copy link
Author

tmarrs commented Jan 16, 2016

Thanks for opening this issue within Apigee. Please let us know if/when it's resolved.

@smolnikov
Copy link
Contributor

@gbrail any updates here?

@whitlockjc
Copy link
Member

I've got someone looking at this and will update when we know something.

@noahdietz
Copy link
Collaborator

We have a PR inflight on Apigee Edge for the necessary API changes, to make --production the default when running npm install, as well as #90 here that toggles this flag when you want to install the devDependencies.

We will update this issue when the fixes are merged and released.

@noahdietz
Copy link
Collaborator

We are still waiting on API changes to release. When those changes are released, we will cut a new release of apigeetool to publish this fix/change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants