Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --production flag to deploynodeapp #90

Merged
merged 1 commit into from
Oct 16, 2017
Merged

add --production flag to deploynodeapp #90

merged 1 commit into from
Oct 16, 2017

Conversation

noahdietz
Copy link
Collaborator

@noahdietz noahdietz commented Oct 11, 2017

add --production flag that toggles the use of --production when resolving modules in Apigee

Fixes #31

@AdamMagaluk
Copy link
Contributor

Would --production=false or -P=false work? I think having the API match the cli when possible makes things easier to remember.

@whitlockjc
Copy link
Member

I agree with @AdamMagaluk. (This might be something we should look into for HF as well.)

@noahdietz
Copy link
Collaborator Author

sure thing

@noahdietz
Copy link
Collaborator Author

The -P short flag is taken though, so I used -I...keying off of "production install"...there aren't many short flags left

@whitlockjc
Copy link
Member

If -P isn't available for short flag, don't use a short flag. I'd rather nothing than a lack of consistency. But then again, this is our own CLI and not npm so a part of me doesn't care.

@noahdietz
Copy link
Collaborator Author

I switched over to using the Query String version of the API rather than the Form version, it wasn't working correctly, I will look into that on the Edge side.

@noahdietz noahdietz changed the title add install-dev flag to deploynodeapp add --production flag to deploynodeapp Oct 12, 2017
@noahdietz noahdietz merged commit 83581a1 into master Oct 16, 2017
@noahdietz noahdietz deleted the b/67165921 branch October 16, 2017 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants