add --bundled-dependencies flag to deploy* #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add bundled-dependencies to deploynodeapp * add upload-modules to deployhostedfunction
AdamMagaluk
approved these changes
Oct 20, 2017
noahdietz
changed the title
AdamMagaluk
approved these changes
Oct 24, 2017
lib/commands/deployproxy.js
Outdated
| @@ -553,7 +602,8 @@ function uploadProxies(opts, request, done) { | |||
| } | |||
|
|
|||
| function runNpm(opts, request, done) { | |||
| if (!opts.remoteNpm) { | |||
| console.log(opts) | |||
There was a problem hiding this comment.
ah good catch, thanks
noahdietz
added a commit
that referenced
this pull request
Oct 26, 2017
* add hosted functions support to getlogs * add deployhostedfunction * Update README for deploy* and getlogs changes * add --bundled-dependencies flag to deploy* (#91) * unify deploy* handling of node_modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds
--bundled-dependenciesflag to thedeployhostedfunctioncommand.This will run an
npm packand use the packaged version of the application to deploy to Hosted Functions, keying off of thebundledDependenciesproperty that packages only the listed dependencies in the result.