Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose kvm cmds #95

Merged
merged 4 commits into from
Oct 20, 2017
Merged

Expose kvm cmds #95

merged 4 commits into from
Oct 20, 2017

Conversation

noahdietz
Copy link
Collaborator

  • exposes the existing KVM commands
  • adds more KVM commands: delete entry, get entry, get map

@AdamMagaluk
Copy link
Contributor

Is there a way to support both env and org level KVMs in this PR? I'd rather not see two sets of top level commands maybe a flag of some sort.

@noahdietz
Copy link
Collaborator Author

Yeah thats a good point.

Could the absence of the --environment -e flag imply its an org-scoped KVM operation? Or is that too subtle?

@noahdietz
Copy link
Collaborator Author

Turns out there are API-scoped KVMs as well, so I'll do this:

  • --organization : org-scoped KVM
  • --organization --environment: env-scoped KVM
  • --organization --api: api-scoped KVM

@noahdietz noahdietz merged commit 765125b into master Oct 20, 2017
@noahdietz noahdietz deleted the expose-kvm-cmds branch October 20, 2017 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdamMagaluk AdamMagaluk AdamMagaluk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noahdietz @AdamMagaluk