Adding functionality to set custom headers, and unset headers in plugins. #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f1erro
reviewed
Nov 17, 2016
| @@ -355,6 +360,20 @@ function _subscribeToSourceRequestEvents(plugins, promises, sourceRequest, sourc | |||
| logger.error(err); | |||
| return reject(err); | |||
| } | |||
|
|
|||
| try { | |||
There was a problem hiding this comment.
Will this work with streaming? This is in the source request 'end' event, and at this point the stream to target request has already been opened and written to (in the 'data' event)
There was a problem hiding this comment.
Doesn't look like it. Giving plugins access to data events throws a wrench in all of this.
…t body has begun streaming.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass at the header functionality.