Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add links to pull request titles #64

Closed
apoclyps opened this issue May 2, 2021 · 0 comments · Fixed by #66
Closed

[Feature] Add links to pull request titles #64

apoclyps opened this issue May 2, 2021 · 0 comments · Fixed by #66
Labels
enhancement New feature or request good first issue Good for newcomers python Pull requests that update Python code

Comments

@apoclyps
Copy link
Owner

apoclyps commented May 2, 2021

Is your feature request related to a problem? Please describe.
I would like to open a pull request by selecting the pull request title in a table listed under Activity.

image

Describe the solution you'd like
When I click on Bump y18n from 3.2.1 to 3.2.2 in /services/client it should open apoclyps/my-dev-space#801" in a browser.

image

Additional context

The title is set here for each pull request

reviews/reviews/layout/helpers.py

Line 42 in fbd8b23

f"[white]{pr.title}",

an example of where the link has been used before can be seen at

reviews/reviews/layout/helpers.py

Line 73 in fbd8b23

tree.add(f"[link=https://www.github.com/{org}/{repo}]{repo}[/link]")

documentation on links is available at https://rich.readthedocs.io/en/latest/markup.html?highlight=link#links
@apoclyps apoclyps added enhancement New feature or request good first issue Good for newcomers python Pull requests that update Python code labels May 2, 2021
yushao2 added a commit to yushao2/reviews that referenced this issue May 2, 2021
@yushao2
Feature-apoclyps#64: Add links to PR titles
40829f6
@yushao2 yushao2 mentioned this issue May 2, 2021
Merged
yushao2 added a commit to yushao2/reviews that referenced this issue May 2, 2021
@yushao2
Feature-apoclyps#64: Add links to PR titles
3c2999c
apoclyps pushed a commit that referenced this issue May 2, 2021
@yushao2
Feature-#64: Add links to PR titles (#66)
71100bc
yushao2 added a commit to yushao2/reviews that referenced this issue May 2, 2021
@yushao2
Merge pull request #1 from apoclyps/main
e53aca2 
Feature-apoclyps#64: Add links to PR titles (apoclyps#66)
@yushao2 yushao2 mentioned this issue May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature-#64: Add links to PR titles yushao2/reviews
1 participant
@apoclyps