-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use fetch polyfill that does not pollute global context [DO NOT MERGE] #661
Conversation
@gajus: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
I am not familiar with TypeScript, beyond the basic concept of its purpose. The test is giving the following errors:
I am assuming this is because I haven't imported type definitions for fetch-ponyfill? |
Yeah we might be able to somehow reuse the typings for |
Closing this, since I think it's better to track it as an issue for now. Trying to merge/close as many PRs as possible before we do a major refactor. |
Currently apollo-client relies on the globally available `fetch` api which causes a number of problems. In the browser apollo-client uses a polyfill which "pollutes" the global scope. This is something a library should probably rather not do. This change is based on previous discussion and work done in apollographql#661 and apollographql#645.
Currently apollo-client relies on the globally available `fetch` api which causes a number of problems. In the browser apollo-client uses a polyfill which "pollutes" the global scope. This is something a library should probably rather not do. This change is based on previous discussion and work done in apollographql#661 and apollographql#645.
Currently apollo-client relies on the globally available `fetch` api which causes a number of problems. In the browser apollo-client uses a polyfill which "pollutes" the global scope. This is something a library should probably rather not do. This change is based on previous discussion and work done in apollographql#661 and apollographql#645.
Currently apollo-client relies on the globally available `fetch` api which causes a number of problems. In the browser apollo-client uses a polyfill which "pollutes" the global scope. This is something a library should probably rather not do. This change is based on previous discussion and work done in apollographql#661 and apollographql#645.
Currently apollo-client relies on the globally available `fetch` api which causes a number of problems. In the browser apollo-client uses a polyfill which "pollutes" the global scope. This is something a library should probably rather not do. This change is based on previous discussion and work done in apollographql#661 and apollographql#645.
Currently apollo-client relies on the globally available `fetch` api which causes a number of problems. In the browser apollo-client uses a polyfill which "pollutes" the global scope. This is something a library should probably rather not do. This change is based on previous discussion and work done in apollographql#661 and apollographql#645.
Currently apollo-client relies on the globally available `fetch` api which causes a number of problems. In the browser apollo-client uses a polyfill which "pollutes" the global scope. This is something a library should probably rather not do. This change is based on previous discussion and work done in apollographql#661 and apollographql#645.
TODO:
#645