use proper singularized version of species in the sample #150
Conversation
|
Oh, sample now uses pojo now so no need for that. I'll just verify that the generated |
marwanad
force-pushed
the
update-sample-app-pluralizing
branch
from
45f3475 to
22a6dfa
Compare
| @@ -6,7 +6,7 @@ ext { | |||
|
|
|||
| dep = [ | |||
| androidPlugin: 'com.android.tools.build:gradle:2.3.0-beta3', | |||
| apolloPlugin: "com.apollographql.android:gradle-plugin:0.1.0", | |||
| apolloPlugin: "com.apollographql.android:gradle-plugin:0.2.0-SNAPSHOT", | |||
There was a problem hiding this comment.
Is it worth having some kind of a dev branch that we build snapshots off instead and make that our target branch? and keep master for the releases?
There was a problem hiding this comment.
I'm not a fan of having development outside of master, we can keep master always pointing to the SNAPSHOTS I think. This shouldn't be pointing to 0.1.0 in the first place
There was a problem hiding this comment.
Ahh, fair enough. That solves it.
marwanad
force-pushed
the
update-sample-app-pluralizing
branch
from
22a6dfa to
05c8f04
Compare
Updates the apollo plugin version to pick up the changes
marwanad
force-pushed
the
update-sample-app-pluralizing
branch
from
05c8f04 to
7fa4f1c
Compare
README.md
Outdated
| MAPPER.map(reader, this); | ||
| } | ||
|
|
||
| public Species(@Nonnull String id, @Nullable String name, @Nullable String classification) { |
There was a problem hiding this comment.
will get rid of this. I just copied off the generated class.
README.md
Outdated
| @@ -134,16 +157,37 @@ public final class DroidDetails implements Query<Operation.Variables> { | |||
| } | |||
| }; | |||
|
|
|||
| public static final Creator CREATOR = new Creator() { | |||
There was a problem hiding this comment.
will get rid of this too.
marwanad
force-pushed
the
update-sample-app-pluralizing
branch
from
00d2633 to
001b21e
Compare
|
@marwanad but does compiler correctly generate interface names for Species ? |
|
@sav007 It does for 0.2-SNAPSHOT, not for 0.1.0. Shall we remove that/update the README to use the snapshot version? |
Should be 🍏 once it picks up the new plugin snapshot.
Closes #77