Resolve null pointer exception on detail screen #1591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#940 references a NullPointerException within the Java sample app that happens when child objects of the EntryDetailQuery response are not null checked and properties of these objects are accessed. A switch statement linter error was also removed as the switch statement only contained one branch alongside a default statement
Just doing some tidying up while I am in this class. The method intializeUserInterface() is now where all the loading of the View properties takes place, and I also created a method for setting the Repository data into the user interface as well.
|
@paynemiller92: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
The agreement has been signed 🖊 ! |
...-sample/src/main/java/com/apollographql/apollo/sample/detail/GitHuntEntryDetailActivity.java
Show resolved
Hide resolved
martinbonnin
approved these changes
Sep 16, 2019
|
@martinbonnin who can merge this? Is there a merge schedule? I want to tackle some more PRs 😄 |
|
I don't have merge rights actually. You'll have to wait for one of the maintainers to look at your pull request. |
digitalbuddha
approved these changes
Sep 17, 2019
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview of Changes (TL;DR)
Related Issues
#940
Details
I wasn't able to replicate the exact crash (if there is one, the info on that ticket is a little skimpy!) However, I did several Android Studio Linter warnings, NullPointerExceptions being a few of them. I removed all the Linter warnings from the
GitHuntEntryDetailActivityclass and I cleaned up the code for readability (the whole point of a sample app is to quickly educate developers on how to use the tool, cleaner code makes this easier!)