Update sample app withe the latest changes to compiler #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipecsl
approved these changes
Feb 6, 2017
| @@ -31,10 +32,12 @@ | |||
| .baseUrl(BASE_URL) | |||
| .client(okHttpClient) | |||
| .addCallAdapterFactory(RxJava2CallAdapterFactory.create()) | |||
| .addConverterFactory(new ApolloConverterFactory.Builder().build()) | |||
| .addConverterFactory(new ApolloConverterFactory.Builder() | |||
| .withResponseFieldMapper(FeedQuery.Data.class, new FeedQuery.Data.Mapper(FeedQuery.Data.FACTORY)) | |||
There was a problem hiding this comment.
so sorry could you explain this line again. Will we need to register every object or is this for a particular custom field
There was a problem hiding this comment.
Yes user must provide Mapper instance for each query top level Data class. Converter then will use it to parse query response. So basically number of queries == number of mapper registrations
There was a problem hiding this comment.
We will need to update readme in next release
digitalbuddha
approved these changes
Feb 6, 2017
|
thanks lgtm!
…On Mon, Feb 6, 2017 at 5:13 PM, Ivan Savytskyi ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In apollo-sample/src/main/java/com/example/apollographql/
sample/SampleApplication.java
<#163>:
> @@ -31,10 +32,12 @@
.baseUrl(BASE_URL)
.client(okHttpClient)
.addCallAdapterFactory(RxJava2CallAdapterFactory.create())
- .addConverterFactory(new ApolloConverterFactory.Builder().build())
+ .addConverterFactory(new ApolloConverterFactory.Builder()
+ .withResponseFieldMapper(FeedQuery.Data.class, new FeedQuery.Data.Mapper(FeedQuery.Data.FACTORY))
Yes user must provide Mapper instance for each query top level Data class.
Converter then will use it to parse query response. So basically number of
queries == number of mapper registrations
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#163>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AEUX3AMxMroiEKCRgo1gOkns2A7qSSNeks5rZ5rvgaJpZM4L3x-U>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.