Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the deprecation message #1728

Merged
merged 3 commits into from
Nov 6, 2019
Merged

Fix the deprecation message #1728

merged 3 commits into from
Nov 6, 2019

Conversation

martinbonnin
Copy link
Contributor

@martinbonnin martinbonnin commented Nov 5, 2019 •
edited
Loading

The deprecation message was erroneously mentioning schemaFilePath instead of schemaPath.

Also detect when schemaFilePath used to be relative and try to keep it relative.

See #1728

@martinbonnin martinbonnin mentioned this pull request Nov 5, 2019
Closed
@sav007 sav007 merged commit 566524d into apollographql:master Nov 6, 2019
@martinbonnin martinbonnin deleted the fix-the-deprecation-message branch November 6, 2019 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DSteve595 DSteve595 DSteve595 approved these changes

@sav007 sav007 sav007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinbonnin @sav007 @DSteve595