Fix generation of nested structures with the same name results in compiler errors

[sav007]

Closes #169

[digitalbuddha]

what happens if nested twice? tbh I'd prefer HeroDetailQuery$$1

[sav007]

It will be HeroDetailQuery$$

[digitalbuddha]

And just for clarity 5 would be Query$$$$$ so just as example imagine you see following in logs...
NullPointerExxeption: Foo$$$$ is null

Will you be able to tell without dragging your finger in screen whether that was 4 or 5 dollar signs.
I don't feel strongly about it but can see it leading to confusing traces. As example rxjava does Action0 - Action9

[sav007]

Not sure why we initially decided to go with $, but it's really easy to change in compiler. But the idea is that in most cases you won't have such issue with more than 2-3 nested classes with the same name. But I don't have any strong opinion for this as Hero4 and Hero$$$$ from my perspective is the same evil, and for sure I will try to avoid such queries with the same nested names (will use aliases)

[sav007]

@digitalbuddha so are we changing $ to number or leaving as is?

[digitalbuddha]

I prefer number but you make the call :-)

[digitalbuddha]

Now you can blame me if people don't like it ☺️

[digitalbuddha]

com.apollographql.android.compiler.CodeGenTest >  generateExpectedClasses[pojo_fragment_with_inline_fragment] FAILED
    org.junit.ComparisonFailure at CodegenTest.kt:31