Rename all singular CompilationUnit references to singular #1951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasomaniac
reviewed
Jan 27, 2020
| * The apollo plugin will add the {@link CompilationUnit} as it creates them | ||
| */ | ||
| internal val compilationUnits = project.container(CompilationUnit::class.java) | ||
| internal val compilationUnit = project.container(CompilationUnit::class.java) |
There was a problem hiding this comment.
This one is a container (which extends from Set) and internal. I think we should keep this one plural.
|
|
||
| override fun onCompilationUnits(action: Action<CompilationUnit>) { | ||
| compilationUnits.all(action) |
There was a problem hiding this comment.
What about keeping the old one and doing:
fun onCompilationUnits(action: Action<CompilationUnit>) {
throw Exception("please use onCompilationUnit {} instead")
}
And then we remove that old version in a couple of months ? This API is new from 1.3.0 so presumably not that many people are using it but that'll make a nicer deprecation path for the users that use it.
| * | ||
| * Please see [onCompilationUnit] | ||
| */ | ||
| @Deprecated("There is a typo. Please use onCompilationUnit instead", replaceWith = ReplaceWith("onCompilationUnit")) |
martinbonnin
approved these changes
Jan 28, 2020
tasomaniac
approved these changes
Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #1947: rename almost all references of
CompilationUnitto singular.