update the setup instructions #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sav007
reviewed
Feb 14, 2017
README.md
Outdated
|
|
||
| ```groovy | ||
|
|
||
| ext { | ||
| kotlinVersion = '1.0.6' |
There was a problem hiding this comment.
Do we need this for sample?
sav007
reviewed
Feb 14, 2017
README.md
Outdated
| } | ||
| repositories { | ||
| jcenter() | ||
| maven { url "https://jitpack.io" } |
There was a problem hiding this comment.
what dependency required this maven repo?
sav007
reviewed
Feb 14, 2017
README.md
Outdated
| apply plugin: 'com.apollographql.android' | ||
|
|
||
| dependencies { | ||
| compile 'com.apollographql.android:api:0.1.0' |
There was a problem hiding this comment.
I believe plugin adds dep to api internally, so we don't need it explicitly, but we need to verify this
|
@sav007 updated with feedback, thanks! |
sav007
reviewed
Feb 14, 2017
README.md
Outdated
|
|
||
| dependencies { | ||
| compile 'com.squareup.retrofit2:retrofit:2.1.0' | ||
| compile 'com.apollographql.android:converter-pojo:0.1.0' |
There was a problem hiding this comment.
compile 'com.apollographql.android:converter-pojo:0.1.0' >> compile 'com.apollographql.android:converter:0.2.1-SNAPSHOT'
There was a problem hiding this comment.
might as well use dep.apolloConverter
|
+1, thanks :) |
sav007
approved these changes
Feb 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The readme had laughable setup instructions. Laughable as in how funny it was that the gradle instructions were incorrect/incomplete :-)
This pr adds proper build.gradle configurations
close #196