-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flatten class generation #392
Merged
sav007
merged 11 commits into
apollographql:master
from
sav007:feature/flatten-class-structure
Apr 5, 2017
Merged
Flatten class generation #392
sav007
merged 11 commits into
apollographql:master
from
sav007:feature/flatten-class-structure
Apr 5, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use compiler NullableValueType enum instead of plugin
sav007
requested review from
brianPlummer,
BenSchwab,
digitalbuddha and
marwanad
April 4, 2017 00:17
brianPlummer
approved these changes
Apr 4, 2017
@BenSchwab @marwanad @digitalbuddha any comments here? |
BenSchwab
approved these changes
Apr 5, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks - this makes the generated code seem much more approachable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue: with nested class generation approach the nested class name can be too long, for example
UpdateCheckoutShippingAddressQuery.Data.CheckoutShippingAddressUpdate.Checkout.LineItemConnection.LineItemEdge.LineItem.Variant
Proposal: change the way how classes to be generated, so instead of fully nested classes make the structure more flat, for example:
This will reduce the nested levels in class names: