Add Factory to create NormalizedCaches injected with Scalar adapters #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the CustomScalarType serializers.
BenSchwab
force-pushed
the
bschwab--custom-scalar-sql
branch
from
959cb12 to
ddf8946
Compare
sav007
reviewed
Apr 10, 2017
| * An adapter used to serialize and deserialize Record fields. Record object types will be serialized to | ||
| * {@link CacheReference}. | ||
| */ | ||
| public final class RecordFieldAdapter { |
There was a problem hiding this comment.
Should we move this class out from /sql package as it's seems more generic and not specific to sql
sav007
reviewed
Apr 10, 2017
| import javax.annotation.Nonnull; | ||
| import javax.annotation.Nullable; | ||
|
|
||
| public abstract class CacheStore { |
There was a problem hiding this comment.
Not sure if we need to call it ApolloCacheStore?
sav007
reviewed
Apr 10, 2017
| EvictionPolicy evictionPolicy, | ||
| Optional<NormalizedCacheFactory> secondaryNormalizedCache) { | ||
| super(recordFieldAdapter); | ||
| if (secondaryNormalizedCache.isPresent()) { |
There was a problem hiding this comment.
nit: I guess it would be better:
this.secondaryCache = secondaryNormalizedCache.transform(it -> it.createNormalizedCache(recordFieldAdapter)));
sav007
reviewed
Apr 10, 2017
| @@ -70,8 +86,8 @@ public LruNormalizedCache(EvictionPolicy evictionPolicy, NormalizedCache seconda | |||
| } | |||
|
|
|||
| @Nonnull @Override public Set<String> merge(Record apolloRecord) { | |||
| if (secondaryCacheStore.isPresent()) { | |||
| secondaryCacheStore.get().merge(apolloRecord); | |||
| if (secondaryCache.isPresent()) { | |||
There was a problem hiding this comment.
I wish we selected Java8 Optional implementation for internal use.
this can be replaced with Java8 optional:
secondaryCache.ifPresent(it -> it.merge(apolloRecord))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #401
Using a factory pattern to manage the complexity of making sure that normalized cache implementations are injected with the same scalar adapter set as is set in the
ApolloClientBuilder.