Add memoizing toString()/hashCode() #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sav007
requested review from
brianPlummer,
BenSchwab,
digitalbuddha and
marwanad
|
So some of us were discussing this and think that the synchronized block is actually overkill, and that the cost of re-calculating is probably less than the cost of the synchronized lock. I'd say just keep it simple and skip it. @digitalbuddha thoughts? |
|
I agree skip it. |
BenSchwab
approved these changes
Apr 18, 2017
|
@digitalbuddha @hzsweers any comments? |
digitalbuddha
approved these changes
Apr 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #420
Similar result to what AutoValue Memoized generates.
@hzsweers