Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generatePrimitiveTypes option to Java codegen #4407

Merged
merged 7 commits into from
Sep 21, 2022

Conversation

BoD
Copy link
Contributor

@BoD BoD commented Sep 20, 2022

See #4399

@netlify
Copy link

netlify bot commented Sep 20, 2022

Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit 523da36
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/6329c278b13bb4000a0bc075

* The minimized GraphQL document being sent to the server to save a few bytes.
* The un-minimized version is:
*
* query JavaPrimitiveQuery($input: MyInput, $nullableInt: Int, $nonNullableInt: Int!) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a nonNullable variable with a default value?


input MyInput {
nullableInt: Int
nonNullableInt: Int!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a nonNullable int with a default value?

Copy link
Contributor

@martinbonnin martinbonnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EZ PZ! 🚀

@BoD BoD merged commit 2f6448b into main Sep 21, 2022
@BoD BoD deleted the java-codegen-primitive-types branch September 21, 2022 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants