Java codegen: add support for Optional or nullable fields #4411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-android-docs canceled.
|
BoD
commented
Sep 23, 2022
apollo-api/src/commonMain/kotlin/com/apollographql/apollo3/api/Adapters.kt
Outdated
Show resolved
Hide resolved
...-compiler/src/main/kotlin/com/apollographql/apollo3/compiler/codegen/java/helpers/Builder.kt
Show resolved
Hide resolved
apollo-api/src/commonMain/kotlin/com/apollographql/apollo3/api/Adapters.kt
Show resolved
Hide resolved
apollo-compiler/src/main/kotlin/com/apollographql/apollo3/compiler/Options.kt
Outdated
Show resolved
Hide resolved
apollo-compiler/src/main/kotlin/com/apollographql/apollo3/compiler/Options.kt
Outdated
Show resolved
Hide resolved
apollo-compiler/src/main/kotlin/com/apollographql/apollo3/compiler/Options.kt
Outdated
Show resolved
Hide resolved
apollo-compiler/src/main/kotlin/com/apollographql/apollo3/compiler/Options.kt
Outdated
Show resolved
Hide resolved
apollo-compiler/src/main/kotlin/com/apollographql/apollo3/compiler/Options.kt
Outdated
Show resolved
Hide resolved
apollo-gradle-plugin-external/src/main/kotlin/com/apollographql/apollo3/gradle/api/Service.kt
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,47 @@ | |||
| plugins { | |||
| id("org.jetbrains.kotlin.jvm") | |||
There was a problem hiding this comment.
It might make sense to write these tests in Java to double check ergonomics. In particular, I'm expecting Java users to call Optional.present(value) instead of new Optional.Present(value) and all these kind of things.
There was a problem hiding this comment.
Suggested change
| id("org.jetbrains.kotlin.jvm") | |
| id("java") |
| } | ||
|
|
||
| dependencies { | ||
| implementation(golatac.lib("apollo.runtime")) |
There was a problem hiding this comment.
Also make the test work without apollo-runtime if possible?
apollo-api/src/commonMain/kotlin/com/apollographql/apollo3/api/Adapters.kt
Outdated
Show resolved
Hide resolved
martinbonnin
approved these changes
Sep 26, 2022
martinbonnin
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4337