Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java codegen: Nullability annotations on generics #4419

Merged
merged 4 commits into from
Sep 30, 2022

Conversation

BoD
Copy link
Contributor

@BoD BoD commented Sep 30, 2022

Sadly this could only be done with the JetBrains annotations

Resolves #4417

@netlify
Copy link

netlify bot commented Sep 30, 2022

Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit e578c8a
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/6336d7f864635b0009b51483

@@ -12,7 +12,7 @@ cache = "2.0.2"
dokka = "1.7.10"
guava = "31.1-jre"
javaPoet = "1.13.0"
jetbrains-annotations = "13.0"
jetbrains-annotations = "23.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

Copy link
Contributor

@martinbonnin martinbonnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That went smoothly 👍

@BoD BoD merged commit 0bb18b4 into main Sep 30, 2022
@BoD BoD deleted the java-jetbrains-annotations-on-types branch September 30, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Java codegen: Nullability annotations on generics (e.g. List<@nullable Integer>)
2 participants