Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-module: fail if inconsistent generateDataBuilders parameters #4462

Merged
merged 5 commits into from
Oct 18, 2022
Merged

Multi-module: fail if inconsistent generateDataBuilders parameters #4462

merged 5 commits into from
Oct 18, 2022

Conversation

martinbonnin
Copy link
Contributor

@netlify
Copy link

netlify bot commented Oct 17, 2022 •
edited
Loading

✅ Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit 65af59a
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/634d711f4a0d5b00088169ff

@martinbonnin martinbonnin mentioned this pull request Oct 17, 2022
Closed
BoD
BoD approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martinbonnin martinbonnin merged commit 1bb9682 into main Oct 18, 2022
@martinbonnin martinbonnin deleted the data-builders-multi-module branch October 18, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoD BoD BoD approved these changes

@sav007 sav007 Awaiting requested review from sav007

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Data Builders] Generating classes which are not used in queries
2 participants
@martinbonnin @BoD