Data builders: only generate used fields #4472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-android-docs canceled.
|
BoD
approved these changes
Oct 21, 2022
...pollo-gradle-plugin-external/src/main/kotlin/com/apollographql/apollo3/gradle/api/Service.kt
Outdated
Show resolved
Hide resolved
…ollographql/apollo3/gradle/api/Service.kt Co-authored-by: Benoit Lubek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up of this slack discussion
One of the main motivations behind data builders was to reduce the amount of generated code and make sure it's not subject to exponential blowup.
Data builders generate code that is O(schemaSize) while test builders generate code that is O(sumOfResponseSizeOverAllOperations). In general this should be more predictable but if the schema is large, there is an upfront cost that make the data builders actually generate more code.
This pull request tracks field usages so that only fields that are used in operation are generated in builders.
@eduardb let me know what you think