Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐘 Use registerJavaGeneratingTask #4486

Merged
merged 6 commits into from
Nov 3, 2022
Merged

🐘 Use registerJavaGeneratingTask #4486

merged 6 commits into from
Nov 3, 2022

Conversation

martinbonnin
Copy link
Contributor

@martinbonnin martinbonnin commented Nov 2, 2022

Use variant.registerJavaGeneratingTask instead of kotlin.sourceSets["main"].kotlin.serDir() so that the generated sources are marked as "generated" and not picked up by lint (by default).

This doesn't use the new AGP variant APIs just yet since they're incubating and also change the codegen task output dir so it's a potentially more intrusive change.

Closes #4478

@netlify
Copy link

netlify bot commented Nov 2, 2022

Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit 6349723
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/636301f7a237c30008b15860

Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated sources are scanned by Android lint
2 participants