Don't publish legacy js artifacts #4591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-android-docs canceled.
|
| @@ -252,6 +254,31 @@ abstract class DefaultApolloExtension( | |||
| } | |||
| } | |||
|
|
|||
| @Suppress("ObjectLiteralToLambda") | |||
| private fun registerCheckLegacyJsTargetTask(): TaskProvider<Task> { | |||
| return project.tasks.register(ModelNames.checkLegacyJsTarget()) { | |||
There was a problem hiding this comment.
Do we need a task for that? Could we just fail at configuration time, maybe using afterEvaluate {} 🙃 ?
There was a problem hiding this comment.
Haha I guess! I'll have a look.
...external/src/main/kotlin/com/apollographql/apollo3/gradle/internal/DefaultApolloExtension.kt
Outdated
Show resolved
Hide resolved
…ollographql/apollo3/gradle/internal/DefaultApolloExtension.kt Co-authored-by: Martin Bonnin <[email protected]>
martinbonnin
approved these changes
Dec 19, 2022
| val kotlin = project.extensions.findByName("kotlin") as? KotlinMultiplatformExtension | ||
| val hasLegacyJsTarget = kotlin?.targets?.any { target -> target is KotlinJsTarget && target.irTarget == null } == true | ||
| check(!hasLegacyJsTarget) { | ||
| "Apollo: LEGACY js target is not supported by Apollo, please use IR." |
There was a problem hiding this comment.
We need to add something in the CHANGELOG about this, certainly link to the Kotlin changelog too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4590