Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: Always put the APQ interceptor last in the interceptors list #4628

Merged
merged 2 commits into from
Jan 12, 2023
Merged

runtime: Always put the APQ interceptor last in the interceptors list #4628

merged 2 commits into from
Jan 12, 2023

Conversation

martinbonnin
Copy link
Contributor

Closes #4617

@martinbonnin martinbonnin requested a review from BoD as a code owner January 11, 2023 20:01
@netlify
Copy link

netlify bot commented Jan 11, 2023 •
edited
Loading

✅ Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit 150bc4c
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/63bf15aaff1f9600087d53dc

BoD
BoD approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martinbonnin martinbonnin merged commit eec61e7 into main Jan 12, 2023
@martinbonnin martinbonnin deleted the apq-cache branch January 12, 2023 09:01
martinbonnin added a commit that referenced this pull request Jan 13, 2023
@martinbonnin
runtime: Always put the APQ interceptor last in the interceptors list (…
03ec6c7 
…#4628)

* add a test

* special case for the apqInterceptor
martinbonnin added a commit that referenced this pull request Feb 27, 2023
@martinbonnin
Revert "runtime: Always put the APQ interceptor last in the intercept…
38b182b 
…ors list (#4628)"

This reverts commit 03ec6c7.
martinbonnin added a commit that referenced this pull request Feb 27, 2023
@martinbonnin
Runtime: Allow to register interceptors after the APQ interceptor (#4709
d99f828 
)

* Revert "runtime: Always put the APQ interceptor last in the interceptors list (#4628)"

This reverts commit 03ec6c7.

* add a test

* put back the test and fail on bad configuration

* update CONTRIBUTING.md

* update 4.0.md

* typo + incubating cache
@martinbonnin martinbonnin mentioned this pull request Mar 15, 2023
Merged
@martinbonnin martinbonnin mentioned this pull request Apr 3, 2023
Closed
This was referenced Apr 26, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoD BoD BoD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

toFlow() and .watch() result in IllegalArgumentException: Flow has more than one element
2 participants
@martinbonnin @BoD