Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a @JsName annotation to Operation.name() #4643

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Conversation

BoD
Copy link
Contributor

@BoD BoD commented Jan 19, 2023

A fix for #4640.

I was wondering why nobody had this problem before, especially with id (a common argument name) - turns out we've had @JsName on id() since JS was introduced.

@BoD BoD requested a review from martinbonnin as a code owner January 19, 2023 12:44
@netlify
Copy link

netlify bot commented Jan 19, 2023

Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit 93a73ad
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/63c93b1a8af5d500085af4d7

@BoD BoD merged commit d04472a into main Jan 19, 2023
@BoD BoD deleted the js-operation-name-function branch January 19, 2023 14:55
BoD added a commit that referenced this pull request Mar 14, 2023
@martinbonnin martinbonnin mentioned this pull request Mar 15, 2023
@martinbonnin martinbonnin mentioned this pull request Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants