Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecation on connectToAndroidSourceSet because alternative have issues too #4674

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Remove deprecation on connectToAndroidSourceSet because alternative have issues too #4674

merged 1 commit into from
Feb 9, 2023

Conversation

martinbonnin
Copy link
Contributor

See #4669

  • registerJavaGeneratingTask fails on incremental build in unit tests.
  • connectToAndroidSourceSet fails to mark generated files as "generated" for lint purposes

Between both issues, it feels better to have something that compiles. This can be overriden from Gradle files if needed.

@martinbonnin martinbonnin requested a review from BoD as a code owner February 9, 2023 13:53
@netlify
Copy link

netlify bot commented Feb 9, 2023 •
edited
Loading

✅ Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit 3bc996b
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/63e4fadefe6f8f0009d9ab0a

BoD
BoD approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martinbonnin martinbonnin merged commit af534cf into main Feb 9, 2023
@martinbonnin martinbonnin deleted the revert-registerJavaGeneratingTask branch February 9, 2023 17:25
BoD pushed a commit that referenced this pull request Mar 14, 2023
@martinbonnin @BoD
remove deprecation on connectToAndroidSourceSet because alternative h…
acda49c 
…ave issues too (#4674)

See #4669

(cherry picked from commit af534cf)
@martinbonnin martinbonnin mentioned this pull request Mar 15, 2023
Merged
@martinbonnin martinbonnin mentioned this pull request Apr 3, 2023
Closed
@martinbonnin martinbonnin mentioned this pull request Sep 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoD BoD BoD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinbonnin @BoD