Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java codegen: fix h nameclash in hashCode #4715

Merged
merged 2 commits into from
Feb 28, 2023
Merged

Conversation

martinbonnin
Copy link
Contributor

Closes #4712

Many thanks @KnyCeg for catching this 🙏

@martinbonnin martinbonnin requested a review from BoD as a code owner February 27, 2023 23:01
@netlify
Copy link

netlify bot commented Feb 27, 2023

Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit 81efcdd
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/63fd36380157c800087d29f0

Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@martinbonnin martinbonnin merged commit 2222360 into main Feb 28, 2023
@martinbonnin martinbonnin deleted the fix-h-nameclash branch February 28, 2023 13:57
BoD pushed a commit that referenced this pull request Mar 14, 2023
* add a tests

* fix nameclash in hashcode

(cherry picked from commit 2222360)
@martinbonnin martinbonnin mentioned this pull request Mar 15, 2023
@martinbonnin martinbonnin mentioned this pull request Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems when generating Java Classes for Types that contain a fieldName "h"
2 participants