Add multipart subscriptions test #4738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-android-docs canceled.
|
martinbonnin
force-pushed
the
subscriptions-over-multipart-test
branch
from
7bca2f8 to
2a179ea
Compare
martinbonnin
commented
Mar 8, 2023
| private companion object { | ||
| private const val EMPTY = 0 | ||
| private const val PAYLOAD = 1 | ||
| private const val OTHER = 2 |
There was a problem hiding this comment.
TIL: you still need those fields to be private even if the companion itself is private. I'm guessing because there are JVM static fields on HttpNetworkTransport, not sure...
There was a problem hiding this comment.
For the record, this is not a binary-compatibility-validator issue. Adding const makes the static field public:
class Test {
private companion object {
// generates a `public static final String toto = "Hello";`
const val field = "Hello"
}
}There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.