[Runtime] throw ApolloNetworkException instead of ApolloParseException on IOException #5068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… instead of ApolloParseException
✅ Deploy Preview for apollo-android-docs canceled.
|
BoD
approved these changes
Jul 6, 2023
...runtime/src/commonMain/kotlin/com/apollographql/apollo3/network/http/HttpNetworkTransport.kt
Outdated
Show resolved
Hide resolved
…ql/apollo3/network/http/HttpNetworkTransport.kt Co-authored-by: Benoit Lubek <[email protected]>
martinbonnin
commented
Jul 6, 2023
| ApolloParseException( | ||
| message = "EOFException while parsing the HTTP network response", | ||
| cause = throwable | ||
| ) |
There was a problem hiding this comment.
This is an interesting one. It could be argued that EOFException is a network exception if the stream is closed too early
- If there is a
Content-Lengththis doesn't happen because OkHttp has a specificjava.net.ProtocolExceptionfor this - I'm not 100% sure about chunked encoding
- Also not 100% clear about the other engines (Ktor, etc...)
|
Turns out it's not low hanging fruits and this raises more questions. Since it's not critical, I'll close this until we refine the exception handling of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Low hanging fruit, closes #2783.