Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More KDoc and deprecate ApolloClient.Builder.addInterceptors() #5733

Merged
merged 1 commit into from
Mar 18, 2024
Merged

More KDoc and deprecate ApolloClient.Builder.addInterceptors() #5733

merged 1 commit into from
Mar 18, 2024

Conversation

martinbonnin
Copy link
Contributor

@martinbonnin martinbonnin commented Mar 15, 2024 •
edited
Loading

For consistency with other builders. There is addFoo() and foos() but no addFoos()

Closes #5723

@martinbonnin martinbonnin requested a review from BoD as a code owner March 15, 2024 17:41
@netlify Netlify
Copy link

netlify bot commented Mar 15, 2024 •
edited
Loading

✅ Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit 986fb94
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/65f4886054e6bb00085a4586

BoD
BoD approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martinbonnin martinbonnin merged commit d0a2827 into main Mar 18, 2024
9 checks passed
@martinbonnin martinbonnin deleted the deprecated-addInterceptors branch March 18, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoD BoD BoD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove sendApqExtensions and sendDocument from MutableExecutionOptions
2 participants
@martinbonnin @BoD