Add DocumentTransform API #5809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-android-docs canceled.
|
martinbonnin
force-pushed
the
plugin-apis
branch
from
3349019 to
5f5db6d
Compare
|
In light of #5807 (comment), I'd vote for merging this one as experimental so we can play with it. |
BoD
approved these changes
Apr 16, 2024
| @@ -72,10 +72,10 @@ fun ApolloGenerateSourcesBaseTask.layout(): LayoutFactory { | |||
| fun ApolloGenerateSourcesBaseTask.requiresBuildscriptClasspath(): Boolean { | |||
| if (packageNameGenerator != null || operationOutputGenerator != null) { | |||
| if (packageNameGenerator != null) { | |||
| logger.lifecycle("Apollo: packageNameGenerator is deprecated, use Apollo compiler plugins instead") | |||
| logger.lifecycle("Apollo: packageNameGenerator is deprecated, use Apollo compiler plugins instead. See https://go.apollo.dev/ak-compiler-plugins for more details.") | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5807
PS: I also took a quick look at adding an API like
to allow contributing more files to the codegen but I ended up backtracking because the
GQLOperationDefinitionare not available in the codegen phase. All in all, I think this is better served by a custom Gradle task outside of the Apollo Gradle Plugin.