Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codegen: avoid enum value clashing with the getter field #6093

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Codegen: avoid enum value clashing with the getter field #6093

merged 1 commit into from
Aug 5, 2024

Conversation

martinbonnin
Copy link
Contributor

Reproducer:

enum Foo {
  field
}

Because field is the backing field in the context of the getter, we need to scope the identifier better.

@martinbonnin martinbonnin requested a review from BoD as a code owner August 2, 2024 23:47
@netlify Netlify
Copy link

netlify bot commented Aug 2, 2024 •
edited
Loading

✅ Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit 9fb3041
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/66ad701bd1fddb00088bcfe5

BoD
BoD approved these changes Aug 3, 2024
View reviewed changes
Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@martinbonnin martinbonnin merged commit ea26b14 into main Aug 5, 2024
9 checks passed
@martinbonnin martinbonnin deleted the fix-field branch August 5, 2024 10:15
@martinbonnin martinbonnin added this to the 4.0.1 milestone Aug 5, 2024
@jadar
Copy link

jadar commented Aug 5, 2024

Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoD BoD BoD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@martinbonnin @jadar @BoD