Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Note that KeyValueCache ttl is in seconds #3619

Merged
merged 4 commits into from
Dec 18, 2019
Merged

Note that KeyValueCache ttl is in seconds #3619

merged 4 commits into from
Dec 18, 2019

Conversation

lorensr
Copy link
Contributor

@lorensr lorensr commented Dec 18, 2019

No description provided.

lorensr and others added 3 commits December 18, 2019 00:31
@lorensr
Note that KeyValueCache ttl is in seconds
958b24e
@abernix
De-compose interface to improve TSDoc for ttl on KeyValueCache#set.
8b98313 
This introduces a `KeyValueCacheSetOptions` which can be annotated on its
own to hopefully improve the clarity of what unit of time the TTL value is
specified in.

While there was a TSDoc present before, it was on the `set` method itself,
rather than the options, which made it a day late and a buck short of being
as useful as you might hope.
@abernix
Formatting.
703d8c9
abernix
abernix approved these changes Dec 18, 2019
View reviewed changes
Copy link
Member

@abernix abernix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've also adjusted the typings to accommodate a better TSDoc annotation on the options itself which displays this clearly during usage for editors that support it, as seen here:

image

@abernix abernix added this to the Release 2.x milestone Dec 18, 2019
@abernix abernix modified the milestones: Release 2.x, Release 2.9.15 Dec 18, 2019
@abernix abernix merged commit 5af483b into apollographql:master Dec 18, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abernix abernix abernix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 2.9.15
Development

Successfully merging this pull request may close these issues.
2 participants
@lorensr @abernix