Wait on correct Promise in subscription #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not a Promise expert, but the previous code at least read like it was possible for the Promise returned by subscribe to resolve once all the this.pubsub.subscribe Promises resolved but before all of the "push onto this.subscriptions" Promises resolved. If unsubscribe was called too quickly, you could in theory end up calling one of those "push" functions after the `delete this.subscriptions[subId]` line and crashing. In practice the old code does appear to work but this code more accurately shows the intentions.
|
Yeah that's makes sense! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not a Promise expert, but the previous code at least read like it was
possible for the Promise returned by subscribe to resolve once all the
this.pubsub.subscribe Promises resolved but before all of the "push onto
this.subscriptions" Promises resolved. If unsubscribe was called too quickly,
you could in theory end up calling one of those "push" functions after the
delete this.subscriptions[subId]line and crashing.In practice the old code does appear to work but this code more accurately shows
the intentions.
@benjamn this is the code I asked you for advice on, thanks!