Breaking typescript change in 2.5

[VincentLanglet]

In 2.4.1, this was valid:

import { Context } from 'react-apollo';

In 2.5, it's now

import { Context } from 'react-apollo/walkTree';

I think it's because of this commit 66b0945

The walkTree definitions are not exported in index.d.ts

[benjamn]

This change was documented in the changelog for 2.4.0: https://github.com/apollographql/react-apollo/blob/master/Changelog.md#240

[VincentLanglet]

I had no use of the walkTree. Only the Context type.

import { GraphQLRequest } from 'apollo-link';
import { setContext } from 'apollo-link-context';
import { Context } from 'react-apollo';

import authenticator from '../../services/authenticator';

export const authorize = (_: GraphQLRequest, context: Context): Context => {
  const token = authenticator.getUserToken();

  if (!token) {
    return context;
  }

  return {
    ...context,
    headers: {
      ...context.headers,
      Authorization: `Bearer ${token}`,
    },
  };
};

export default setContext(authorize);

The fact walkTree is deprecated, shouldn't deprecate the Context type.
Maybe should it be defined somewhere else.

[benjamn]

@VincentLanglet Ahh, I agree it was a mistake to stop exporting that Context interface. Does #2832 look like it will restore the previous behavior?

[VincentLanglet]

Yes, I think it'll be good since index has export * from './types';