This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
Full dep/devDep updates to latest versions #2873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`walkTree` is no longer used by `react-apollo` (see #2533), but since it was previously exported and made available externally, it is still available (albeit deprecated) until `react-apollo` 3.0. Unfortunately, the current `walkTree` implementation does not fully work with React's new Context API. It can be updated to work with modern versions of React, but the entire point of #2533 is to avoid spending anymore time working on `walkTree`, since its implementation relies on React internals (and is very brittle). Since external use of `walkTree` is very minimal, and since there have been no complaints of `walkTree` not working with React's new Context API since it has been made a standalone module (these problems were only noticed when `walkTree` was being used by `react-apollo`), I think we should leave `walkTree` as is. This commit makes sure `walkTree` passes Typescript compilation, but disables failing tests caused by render tree differences in newer versions of React.
hwillson
commented
Mar 16, 2019
| @@ -31,7 +31,7 @@ export function withMutation< | |||
| if (typeof mapPropsToOptions !== 'function') mapPropsToOptions = () => options as MutationOpts; | |||
|
|
|||
| return ( | |||
| WrappedComponent: React.ComponentType<TChildProps & TProps>, | |||
| WrappedComponent: React.ComponentType<TProps & TChildProps>, | |||
There was a problem hiding this comment.
Switching the TProps & TChildProps order around has no technical merit - it just bugged me!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates all
dependencies/devDependenciesto their latest versions, and includes code (mostly Typescript) changes required by the new versions.One thing to note - these changes only include the bare minimum needed to make
walkTreecompile after the dep updates, and work exactly like it did before (bugs and all). Re-capping from 98adf92):I don't think we should spend anymore time on
walkTree(and will add the above to theCHANGELOG). I know in theory we should make surewalkTreeworks fully with current day React until it's removed (inreact-apollo3.0), but given that its use is now quite minimal, and it still works just like it did before (which is broken with current day React), I really feel spending further time on it is not productive. I also don't want us to be held up on updating the rest ofreact-apolloto work with modern React versions, until we hit 3.0 and can removewalkTree. Definitely let me know if anyone disagrees.Thanks!