Using Reason-Apollo with Create-React-App

[idkjs]

Issue Labels

• has-reproduction
• feature
• docs
• blocking
• good first issue

I took the examples/swapi demo and tried to run it with create-react-app`.
reproduction
This is the error in browser. Project compiles successfully.

Any idea what is going on here?

[emmenko]

Yes, it's because of this bug #80 when you have es6 as output target. Hopefully it will be merged soon 😇

[idkjs]

I tried the fix locally, getting same error.

[emmenko]

Have you clean and rebuild with bsb?

[emmenko]

You can try with my branch otherwise (I'm keeping track of the pending fixes).

"reason-apollo": "emmenko/reason-apollo#pending-patches-0.10.0"

[idkjs]

doesnt work for me. ran clean and rm -rf node_modules lib .merlin reinstalled. Same error. reproduction is updated.

[emmenko]

I'll take a look later at the repo then

[Gregoirevda]

@emmenko This isn't the GraphqlTag is not a function error, happening because of the bindings (might not be an issue with the new bs-platform), but parse is not a function.
graphql-tag is using 3 entry points:
main -> bundle
module and next js -> ES6
For some reason, reason-scripts uses ES6 version and there's an error with this import
var parse = require("graphql/language/parse")
require is not defined which leads to an undefined parse

[Gregoirevda]

as references graphql/graphql-js#1248 and facebook/create-react-app#4085

[br1anchen]

@Gregoirevda did some investigation about CRA(create-react-app) with react-apollo and reason-apollo.
CRA (react-script v1.1.5) works fine with react-apollo(v2.0.4) which requires graphql-tag(v^2.9.2) (graphql).
So I think the problem is how bs-loader loads reason-apollo in this case.
Checked package-specs of reason-apollo:

"package-specs": [
    {
      "module": "es6",
      "in-source": true
    }
  ],

I suspect that's the reason, reason-script uses ES6 module for reason-apollo.
However, bs-loader recommends
using bsb in-source builds, so by set inSource: true as default bs-loader options in reason-script seems fixing the problem.
I made PR for it, even though reason-script will not be actively maintained.
Feel free to fork/tag my forked repo in your package.json to try out.

[Gregoirevda]

Thanks @br1anchen! As you said reason-scripts won't be supported anymore and he recommends switching to parcel rrdelaney/reason-scripts#69 (comment)
I'll make an example of that

[idkjs]

@Gregoirevda any demo of the parcel bsb with reason-apollo? I will take a shot at the example with a head start maybe.