-
Notifications
You must be signed in to change notification settings - Fork 58
webpack uses ES6 and not umd/commonJS #69
Comments
Our webpack config is based off of react-script's, and we're not likely to deviate from that. Is there a reason you need all 3 entry points? |
The 3 entry points are defined in the package.json of a dependency. |
I’m not really sure about the resolution between the three. I recommend playing around with CRA main if you’re unsure. We use the same dependency resultion and webpack config, except we add bs-loader. |
@Gregoirevda @rrdelaney I believe it is similar issue related to this, I changed resolve extension order in
to
then it compiled with |
Tried making a new project pointing on fixed react-scripts 1.1.2, but still have this issue. |
reason-scripts isn't going to be updated, or really support much anymore. I recommend using Parcel with BSB. Closing this because this won't be updated. |
@rrdelaney You should add a warning about this in the main README and mark this package as deprecated in the meantime if it not going to get more updates. I don't think it's clear to a lot of people at the moment that this package is abandoned. In addition to that I've never managed to make Parcel work on a my ReasonReact codebase, there's always some dependency or compilation error, have you had more success on your end? |
@Anahkiasen shoot yea, forgot to do that when I moved it out of reasonml-old |
We use a npm package as a dependency which has 3 entry points:
https://github.com/apollographql/graphql-tag/blob/master/package.json#L5
main
,module
andjsnext:main
for some reason, it is using the ES6 module or jsnext:main entry point, which uses a undefined
require
import statement.Related issue:
apollographql/reason-apollo#95
The text was updated successfully, but these errors were encountered: