Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs failing to build for apollo-router on crates/docs.rs #3305

Closed
o0Ignition0o opened this issue Jun 22, 2023 · 2 comments · Fixed by #3626
Closed

docs failing to build for apollo-router on crates/docs.rs #3305

o0Ignition0o opened this issue Jun 22, 2023 · 2 comments · Fixed by #3626
Assignees
@o0Ignition0o

Comments

@o0Ignition0o
Copy link
Contributor

o0Ignition0o commented Jun 22, 2023 •
edited by abernix
Loading

The latest apollo-router crates are failing to build on docs.rs, as seen here: https://docs.rs/crate/apollo-router/1.26.0/builds

The latest successful docs build is for apollo-router 1.21.0-alpha.0

We will unpin and close this issue once the upstream fix is published.
@o0Ignition0o o0Ignition0o pinned this issue Jun 22, 2023
@o0Ignition0o
Copy link
Contributor Author

Deno has released a version with the fix, putting it back in todo

@abernix abernix changed the title apollo-router docs failed to build docs failing to build for apollo-router on crates/docs.rs Aug 9, 2023
@o0Ignition0o o0Ignition0o self-assigned this Aug 21, 2023
@o0Ignition0o o0Ignition0o mentioned this issue Aug 21, 2023
Merged
o0Ignition0o added a commit that referenced this issue Aug 29, 2023
@o0Ignition0o
Update deno, so we can generate docs again (#3626)
01bb514 
Fix #3305, #3684

Router docs failed to build on crates.io because of a documentation
compile error in Deno.
This updates Deno to the latest version, which allows us to generate
crates.io documentation again.
@Geal Geal mentioned this issue Sep 4, 2023
Merged
@abernix abernix mentioned this issue Sep 4, 2023
Merged
@abernix
Copy link
Member

abernix commented Sep 5, 2023

Our documentation is again building and being published to docs.rs successfully!

@abernix abernix unpinned this issue Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@o0Ignition0o o0Ignition0o

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update deno, so we can generate docs again apollographql/router
2 participants
@abernix @o0Ignition0o