Fix condition that use potential undefined variable and crash the application #1480
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
It's possible to define pieces selected through the property
by
in custom pieces widget.However set
by
to['all']
crashs the application, which try to read a property of an undefined value in an if condition.How to reproduce
Create a custom pieces widget extending
apostrophe-pieces-widgets
with the followingby
restriction:Try to run the application, which will crash with the following error
Fix
Change
if (self.joinById.relationship && (widget.by === 'id'))
to
if (self.joinById && self.joinById.relationship && (widget.by === 'id'))
as
self.joinById
can be undefined