Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace easy_install usage with the pip equivalents #1836

Merged
merged 3 commits into from
Sep 14, 2021

Conversation

steveteahan
Copy link
Contributor

easy_install (used with setup.py install) will install pre-releases
which is unexpected and undesirable behavior.

More information:

pypa/setuptools#855

I tested this by creating a venv with python setup.py install and another with pip install . The diff of the pip freeze output was:

$ diff easy_install.txt pip.txt 
29c29
< jira==2.0.1.0rc1
---
> jira==2.0.0
56c56
< python-jenkins==1.8.0.0a0
---
> python-jenkins==1.7.0
86c86
< wrapt==1.13.0rc3
---
> wrapt==1.12.1

This is exactly what I expect. The pip install ignored alpha and release candidates while easy_install was happy to install versions that we don't want to rely on in production.

easy_install (used with setup.py install) will install pre-releases
which is unexpected and undesirable behavior.

More information:

pypa/setuptools#855
@steveteahan
Copy link
Contributor Author

steveteahan commented Sep 13, 2021

I also built the container before and after this fix with dockerfiles/Dockerfile and confirmed that pre-release packages were being installed for jira, python-jenkins, and wrapt. With this fix, we're now using the stable releases.

Copy link
Contributor

@Piojo Piojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@jmelis jmelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steveteahan steveteahan merged commit dcd5f29 into app-sre:master Sep 14, 2021
@steveteahan steveteahan deleted the use-pip branch September 14, 2021 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants