🐛 Fix missing experienceDidDisappear for embeds

appcues · Feb 29, 2024 · 0eb1a37 · 0eb1a37
1 parent 0b11c1d
commit 0eb1a37
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/Sources/AppcuesKit/Presentation/UI/AppcuesFrameView.swift b/Sources/AppcuesKit/Presentation/UI/AppcuesFrameView.swift
@@ -106,7 +106,8 @@ public class AppcuesFrameView: UIView, StateMachineOwning {
             isHidden = true
             parentViewController?.unembedChildViewController(experienceController)
             configureConstraints(isEmpty: true)
-            completion?()
+            // Complete async so that experienceController.viewDidDisappear gets called before the state machine moves to .idling
+            DispatchQueue.main.async { completion?() }
         case .fade:
             UIView.animate(
                 withDuration: 0.3,
@@ -117,7 +118,8 @@ public class AppcuesFrameView: UIView, StateMachineOwning {
                     self.isHidden = true
                     self.parentViewController?.unembedChildViewController(experienceController)
                     self.configureConstraints(isEmpty: true)
-                    completion?()
+                    // Complete async so that experienceController.viewDidDisappear gets called before the state machine moves to .idling
+                    DispatchQueue.main.async { completion?() }
                 }
             )
         }