Skip to content

Commit

Permalink
♻️ Remove push transaction ID
Browse files Browse the repository at this point in the history
  • Loading branch information
mmaatttt authored and iujames committed Sep 17, 2024
1 parent ce53b57 commit 55806df
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 5 deletions.
2 changes: 0 additions & 2 deletions Sources/AppcuesKit/Push/ParsedNotification.swift
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ internal struct ParsedNotification {
let notificationID: String
let workflowID: String?
let workflowTaskID: String?
let transactionID: String?
let deepLinkURL: URL?
let experienceID: String?
let attachmentURL: URL?
Expand All @@ -37,7 +36,6 @@ internal struct ParsedNotification {

self.workflowID = userInfo["appcues_workflow_id"] as? String
self.workflowTaskID = userInfo["appcues_workflow_task_id"] as? String
self.transactionID = userInfo["appcues_transaction_id"] as? String
self.deepLinkURL = (userInfo["appcues_deep_link_url"] as? String)
.flatMap { URL(string: $0) }
self.experienceID = userInfo["appcues_experience_id"] as? String
Expand Down
1 change: 0 additions & 1 deletion Sources/AppcuesKit/Push/PushMonitor.swift
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,6 @@ internal class PushMonitor: PushMonitoring {
"notification_id": parsedNotification.notificationID,
"workflow_id": parsedNotification.workflowID,
"workflow_task_id": parsedNotification.workflowTaskID,
"transaction_id": parsedNotification.transactionID,
"device_id": storage.deviceID
].compactMapValues { $0 },
isInternal: true
Expand Down
3 changes: 1 addition & 2 deletions Tests/AppcuesKitTests/Push/PushMonitorTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -385,8 +385,7 @@ extension Dictionary where Key == AnyHashable, Value == Any {
"appcues_user_id": "default-00000",
"appcues_notification_id": "DEADBEEF-0000-0000-0000-000000000001",
"appcues_workflow_id": "DEADBEEF-0000-0000-0000-000000000002",
"appcues_workflow_task_id": "DEADBEEF-0000-0000-0000-000000000003",
"appcues_transaction_id": "DEADBEEF-0000-0000-0000-000000000004"
"appcues_workflow_task_id": "DEADBEEF-0000-0000-0000-000000000003"
]
}
}
Expand Down

0 comments on commit 55806df

Please sign in to comment.