feat: Add 'mobile: keys' extension #2156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KazuCocoa
reviewed
Oct 26, 2023
KazuCocoa
reviewed
Oct 28, 2023
KazuCocoa
approved these changes
Oct 28, 2023
There was a problem hiding this comment.
with the appium/WebDriverAgent#798 patched version, it looks good to me
|
thanks for checking it. Let me wait until WDA patch is published and I'll add it into this PR before publishing it. |
|
👍 |
…uitest-driver into keys # Conflicts: # package-lock.json
github-actions bot
pushed a commit
that referenced
this pull request
Oct 30, 2023
## [5.8.0](v5.7.0...v5.8.0) (2023-10-30) ### Features * Add 'mobile: keys' extension ([#2156](#2156)) ([db39d66](db39d66))
|
🎉 This PR is included in version 5.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
jlipps
reviewed
Oct 30, 2023
no we should not because:
|
|
Right, unicode chars did/do not work at least. Key typing speed is also slower than existing send_keys (in my local real device testing) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on appium/WebDriverAgent#797