Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request.url should return nil for situations where it is not applicable #84

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

guoye-zhang
Copy link
Contributor

Regular CONNECT requests and OPTIONS * requests do not have URLs

@guoye-zhang guoye-zhang added kind/bug Feature doesn't work as expected. 🔨 semver/patch No public API change. labels Jan 28, 2025
Copy link

@ekinnear ekinnear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some tests for each of these cases, too?

Copy link

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like Eric, I’m happy with the code but would love to see some tests

@guoye-zhang guoye-zhang enabled auto-merge (squash) January 29, 2025 07:08
@guoye-zhang guoye-zhang merged commit 40ca463 into apple:main Jan 29, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Feature doesn't work as expected. 🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants