Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: git manager #48

Merged
merged 19 commits into from
Jul 22, 2021
Merged

Feat: git manager #48

merged 19 commits into from
Jul 22, 2021

Conversation

luhc228
Copy link
Collaborator

@luhc228 luhc228 commented Jul 19, 2021

Ref: #42

预览图:
2021-07-21 17-45-05 2021-07-21 17_47_05

TODO:

  • 官方文档更新

@luhc228 luhc228 requested a review from fyangstudio July 19, 2021 06:56
@luhc228 luhc228 self-assigned this Jul 19, 2021
@luhc228 luhc228 requested a review from GiveMe-A-Name July 19, 2021 06:59
@fyangstudio
Copy link

  1. 配置 - 名称
  2. 文档指引链接

await writeGitConfig(GLOBAL_GITCONFIG_PATH, gitConfig);
}

export async function getUserGitConfigs() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议注释下,说明怎么取 步骤是什么 可能的问题有什么

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

main/git/config.ts Outdated Show resolved Hide resolved
main/git/ssh.ts Outdated
let currentSSHConfigIndex = -1;
// eslint-disable-next-line no-labels
loopLabel:
for (let index = 0; index < SSHConfigSections.length; index++) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

直接用 array findIndex?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@luhc228
Copy link
Collaborator Author

luhc228 commented Jul 19, 2021

  1. 配置 - 名称
  2. 文档指引链接

image

@luhc228 luhc228 requested a review from fyangstudio July 19, 2021 13:37
@luhc228 luhc228 merged commit c9dd1fc into release-next Jul 22, 2021
@luhc228 luhc228 deleted the feat/git branch July 22, 2021 02:50
@luhc228 luhc228 mentioned this pull request Jul 22, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants