Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to React 18 Mui 5 #1077

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Update to React 18 Mui 5 #1077

wants to merge 17 commits into from

Conversation

K-Markopoulos
Copy link
Collaborator

@K-Markopoulos K-Markopoulos commented Dec 20, 2024

Purpose

Upgrade old version of React to stay up to date and eventually be able to introduce NextJS.

Migrations

  • React: 16 -> 18 - Latest is 19
  • MUI: 4 -> 5 - Latest is 6
  • @testing-library/react: 9 -> 16 (latest) and its dependencies

TODO (before merge)

  • Merge master. This branch is many commits behind.
  • QA the whole app.

Future improvements:

  • Replace deprecated methods.
  • Migrate to latest versions

@K-Markopoulos K-Markopoulos self-assigned this Dec 20, 2024
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This pull request was not sent to the PullRequest network because the pull request is a draft.

Copy link

Build succeeded and deployed at https://aqualink-app-1077.surge.sh
(hash 7142c3d deployed at 2024-12-30T11:05:29)

@K-Markopoulos K-Markopoulos marked this pull request as ready for review December 30, 2024 13:11
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!

What to expect from this code review:
  • Comments posted to any areas of potential concern or improvement.
  • Detailed feedback or actions needed to resolve issues that are found.
  • Turnaround times vary, but we aim to be swift.

@K-Markopoulos you can click here to see the review status or cancel the code review job.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest Breakdown

Reviewable lines of change

+ 11,295
- 8,873

81% Jest Snapshot (tests)
13% TSX
3% TSX (tests)
3% TypeScript
<1% Other

Generated lines of change

+ 646
- 520

Type of change

Feature - These changes are adding a new feature or improvement to existing code.
1 Message
⚠️ Due to its size, this pull request will be reviewed by PullRequest staff before being sent to the reviewer network, and the team will reach out if there are any concerns. After this pull request is sent to the network, please be aware that it will likely have a longer turnaround time and require multiple passes from our reviewers.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✖️ This code review was cancelled. See Details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant